Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change invalid RFC3339 link for valid one #832

Merged
merged 2 commits into from
Sep 12, 2022
Merged

docs: change invalid RFC3339 link for valid one #832

merged 2 commits into from
Sep 12, 2022

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented Sep 9, 2022

image

https://xml2rfc.ietf.org/public/rfc/html/rfc3339.html now returns 404. This PR replaces the no longer valid link for another equivalent one: https://www.rfc-editor.org/rfc/rfc3339.html#section-5.6

Refs #831

This was referenced Sep 9, 2022
Closed
Merged
@char0n
Copy link
Collaborator Author

char0n commented Sep 12, 2022

@fmvilas @derberg @dalelane can you please look at this editorial change? This is currently blocking effort of updating the release branch - #831. Thanks!

@derberg derberg changed the title fix(spec): change invalid RFC3339 link for valid one docs: change invalid RFC3339 link for valid one Sep 12, 2022
@derberg
Copy link
Member

derberg commented Sep 12, 2022

@char0n I changed title to docs: and fix(spec): would trigger a patch release after merge.

docs: is critical for small editorial changes, and then we push it out also directly to the website -> asyncapi/website#938

@derberg derberg mentioned this pull request Sep 12, 2022
Merged
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg
Copy link
Member

derberg commented Sep 12, 2022

/rtm

not waiting for @fmvilas as he is aware of the issue and tried to fix it on his PR -> https://github.com/asyncapi/spec/pull/827/files#r968898025

@asyncapi-bot asyncapi-bot merged commit 9f37dd8 into asyncapi:master Sep 12, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fmvilas
Copy link
Member

fmvilas commented Sep 22, 2022

Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be 3.0.0-next-major-spec.1. There's a notice in the release. Apologies for the noise.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalelane dalelane dalelane approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released on @next-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@char0n @derberg @asyncapi-bot @fmvilas @dalelane